Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

feat(core): remove unused code #334

Merged
merged 1 commit into from
Aug 12, 2021
Merged

feat(core): remove unused code #334

merged 1 commit into from
Aug 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2021

Description

This PR removes the error.ts which is not used and not exported in https://github.com/Zilliqa/Zilliqa-JavaScript-Library/blob/dev/packages/zilliqa-js-core/src/index.ts

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from bb111189, renlulu and teye as code owners August 11, 2021 03:04
@ghost ghost closed this Aug 11, 2021
@ghost ghost reopened this Aug 11, 2021
@ghost ghost force-pushed the feat/remove-unused branch from 581eb27 to 76259fe Compare August 11, 2021 05:46
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #334 (70e42f1) into dev (6add1ea) will increase coverage by 1.37%.
The diff coverage is n/a.

❗ Current head 70e42f1 differs from pull request most recent head 76259fe. Consider uploading reports for the commit 76259fe to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #334      +/-   ##
==========================================
+ Coverage   79.19%   80.57%   +1.37%     
==========================================
  Files          45       44       -1     
  Lines        1817     1786      -31     
  Branches      304      299       -5     
==========================================
  Hits         1439     1439              
+ Misses        377      346      -31     
  Partials        1        1              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6add1ea...76259fe. Read the comment docs.

@bb111189 bb111189 merged commit 7226a44 into dev Aug 12, 2021
@ghost ghost deleted the feat/remove-unused branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants