Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Refactor/eqeqeq #341

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Refactor/eqeqeq #341

merged 2 commits into from
Aug 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2021 •
edited by ghost
Loading

Description

This PR adds https://eslint.org/docs/rules/eqeqeq and fix codes accordingly.

It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

Since its type is either undefined or Account, defaultAccount !== undefined is what we need.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Screen Shot 2021-08-13 at 11 30 10 AM 1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners August 13, 2021 02:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #341 (6ed7bda) into dev (c054901) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #341   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files          44       44           
  Lines        1787     1787           
  Branches      299      299           
=======================================
  Hits         1440     1440           
  Misses        346      346           
  Partials        1        1
Impacted Files Coverage Δ
...kages/zilliqa-js-account/src/transactionFactory.ts 88.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c054901...6ed7bda. Read the comment docs.

@bb111189 bb111189 merged commit 5c2e7cd into dev Aug 13, 2021
@ghost ghost deleted the refactor/eqeqeq branch August 17, 2021 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AmritKumar AmritKumar Awaiting requested review from AmritKumar

@renlulu renlulu Awaiting requested review from renlulu

@teye teye Awaiting requested review from teye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecov-commenter @bb111189