-
Notifications
You must be signed in to change notification settings - Fork 74
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #345 +/- ##
==========================================
- Coverage 80.80% 80.67% -0.14%
==========================================
Files 44 44
Lines 1782 1790 +8
Branches 294 298 +4
==========================================
+ Hits 1440 1444 +4
- Misses 341 345 +4
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Works with the examples! No issues on react.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR refactors and optimizes
randomBytes()
.window.crypto.getRandomValues()
sodium-native
to generate random bytes safelysodium-universal
, we can minimize dependency and the bundle size (32kb -> 1.3kb when Minified + Gzipped) and still support web worker environment.Also, this PR upgrades
@types/node
&prettier
and formats codes in order to use optional chaining without errors.References
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: