Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

refactor(blockchain): comments #351

Merged
merged 1 commit into from
Aug 17, 2021
Merged

refactor(blockchain): comments #351

merged 1 commit into from
Aug 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 17, 2021 •
edited by ghost
Loading

Description

This PR removes unnecessary or outdated comments which are

In this way, we can manage the documentation and code in more consistent and easier way. Otherwise, we will have to update documents in multiple places by doing many copy-and-paste.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from bb111189, renlulu and teye as code owners August 17, 2021 11:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021 •
edited
Loading

Codecov Report

Merging #351 (c76b389) into dev (c48cfd1) will not change coverage.
The diff coverage is n/a.

❗ Current head c76b389 differs from pull request most recent head 10b5f1b. Consider uploading reports for the commit 10b5f1b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #351   +/-   ##
=======================================
  Coverage   80.67%   80.67%           
=======================================
  Files          44       44           
  Lines        1790     1790           
  Branches      298      298           
=======================================
  Hits         1444     1444           
  Misses        345      345           
  Partials        1        1
Impacted Files Coverage Δ
packages/zilliqa-js-blockchain/src/chain.ts 62.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48cfd1...10b5f1b. Read the comment docs.

@bb111189 bb111189 merged commit 1c1a314 into dev Aug 17, 2021
@bb111189 bb111189 deleted the refactor/comments branch August 18, 2021 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renlulu renlulu Awaiting requested review from renlulu

@teye teye Awaiting requested review from teye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecov-commenter @bb111189