This repository was archived by the owner on May 26, 2023. It is now read-only.
fix: prettier #355
Merged
fix: prettier #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #355 +/- ##
==========================================
+ Coverage 80.67% 80.79% +0.12%
==========================================
Files 44 44
Lines 1790 1802 +12
Branches 298 303 +5
==========================================
+ Hits 1444 1456 +12
Misses 345 345
Partials 1 1
Continue to review full report at Codecov.
|
bb111189
approved these changes
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes pre-commit hook by removing
--writeflag inyarn prettier.Expected Behavior: pre-commit hook should exit with
1if not formatted.Actual Behavior: pre-commit hook formats code if not formatted
Also, it ignores
coverage.Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: