This repository was archived by the owner on May 26, 2023. It is now read-only.
Minimize jest related deps #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #357 +/- ##
=======================================
Coverage 80.82% 80.82%
=======================================
Files 44 44
Lines 1804 1804
Branches 306 306
=======================================
Hits 1458 1458
Misses 345 345
Partials 1 1 Continue to review full report at Codecov.
|
bb111189
approved these changes
Aug 19, 2021
54df34d to
419ecbd
Compare
|
resolved conflicts @bb111189 |
|
Also it removes the old integration tests which are not included in CI. |
added 4 commits
August 20, 2021 12:17
…ibrary into feat/minimise-jest-related-deps
bb111189
approved these changes
Aug 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR drops
jest-json-schema,jest-watch-typeaheadand removes the related codes and files to minimize jest related dependencies which are non-essential.Also it removes the old integration tests which are not included in CI.
I think we can focus on more unit testing and rewrite integration tests after that.
Motivation and Context
To upgrade Jest for #356, we will face some breaking changes. To handle those changes in simpler and easier way, we can reduce the complexity for the deps when the deps are not essential.
How has this been tested?
yarn bootstrap && yarn testScreenshots (if appropriate):
Types of changes
Checklist: