Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Remove unused deps #363

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Remove unused deps #363

merged 2 commits into from
Aug 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 21, 2021

Description

This PR removes

  • protobufjs as it was was added with dc7c611 and moved into its own package with f75d0
  • rollup-plugin-node-builtins which is not used in bundle.ts unlike other plugins.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

noel added 2 commits August 21, 2021 13:09
moved protobuf into its own package with f75d0
a76a0206fbc6174e0d056acd46395793070
rollup-plugin-node-globals is not used in bundle.ts unlike other plugins
@ghost ghost requested review from AmritKumar and bb111189 as code owners August 21, 2021 04:14
@ghost ghost changed the title Build/remove unused deps Remove unused deps Aug 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #363 (3d83198) into dev (519b8f8) will not change coverage.
The diff coverage is n/a.

❗ Current head 3d83198 differs from pull request most recent head c6dbc58. Consider uploading reports for the commit c6dbc58 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #363   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          44       44           
  Lines        1804     1804           
  Branches      306      306           
=======================================
  Hits         1458     1458           
  Misses        345      345           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 519b8f8...c6dbc58. Read the comment docs.

@bb111189 bb111189 merged commit 98da52e into dev Aug 21, 2021
@bb111189 bb111189 deleted the build/remove-unused-deps branch August 21, 2021 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants