Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

refactor(contract): use blockchain pkg #379

Merged
merged 1 commit into from
Oct 18, 2021
Merged

refactor(contract): use blockchain pkg #379

merged 1 commit into from
Oct 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2021 •
edited by ghost
Loading

Description

This PR uses blockchain package to remove redundant logics.

Dependency Graph
zil-js-dep-graph 002

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners September 6, 2021 01:18
@ghost ghost changed the title Fix/dep fix: reuse blockchain pkg Sep 6, 2021
@ghost ghost marked this pull request as draft September 6, 2021 01:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021 •
edited
Loading

Codecov Report

Merging #379 (282e7b4) into dev (96c014e) will increase coverage by 0.20%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #379      +/-   ##
==========================================
+ Coverage   81.28%   81.49%   +0.20%     
==========================================
  Files          43       43              
  Lines        1811     1945     +134     
  Branches      334      361      +27     
==========================================
+ Hits         1472     1585     +113     
- Misses        338      359      +21     
  Partials        1        1
Impacted Files Coverage Δ
packages/zilliqa-js-contract/src/contract.ts 82.83% <80.00%> (+0.88%) ⬆️
packages/zilliqa-js-blockchain/src/chain.ts 70.27% <0.00%> (+3.27%) ⬆️
packages/zilliqa-js-blockchain/src/network.ts 60.00% <0.00%> (+60.00%) ⬆️
packages/zilliqa-js-blockchain/src/index.ts 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c014e...282e7b4. Read the comment docs.

@ghost ghost force-pushed the fix/dep branch 2 times, most recently from 2e3d3f6 to d874522 Compare September 6, 2021 07:10
@ghost ghost mentioned this pull request Sep 24, 2021
Merged
5 tasks
@ghost ghost marked this pull request as ready for review September 29, 2021 06:05
@ghost ghost changed the title fix: reuse blockchain pkg refactor(contract): use blockchain pkg Sep 29, 2021
@bb111189 bb111189 merged commit a4aeae1 into dev Oct 18, 2021
@bb111189 bb111189 deleted the fix/dep branch October 18, 2021 02:58
@ghost ghost mentioned this pull request Oct 22, 2021
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AmritKumar AmritKumar Awaiting requested review from AmritKumar

@renlulu renlulu Awaiting requested review from renlulu

@teye teye Awaiting requested review from teye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecov-commenter @bb111189