Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

build: remove unused pkg #380

Merged
merged 2 commits into from
Sep 6, 2021
Merged

build: remove unused pkg #380

merged 2 commits into from
Sep 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2021

Description

This PR removes crypto and util dependencies in core package. It's because crypto and util packages are not used in the core package. Note the current dependency graph:

zil-js-dep-graph 001

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners September 6, 2021 07:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2021

Codecov Report

Merging #380 (8bdb6e8) into dev (af921bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #380   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          44       44           
  Lines        1804     1804           
  Branches      329      329           
=======================================
  Hits         1461     1461           
  Misses        342      342           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af921bb...8bdb6e8. Read the comment docs.

@ghost ghost changed the title build(core): remove unused pkg build: remove unused pkg Sep 6, 2021
@ghost ghost requested a review from renlulu September 6, 2021 09:01
@bb111189 bb111189 merged commit 39493f7 into dev Sep 6, 2021
@bb111189 bb111189 deleted the build/rm-unused-pkg branch September 6, 2021 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants