Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

build: typescript v4 #388

Merged
merged 2 commits into from
Sep 16, 2021
Merged

build: typescript v4 #388

merged 2 commits into from
Sep 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 16, 2021

Description

This PR closes #369 by using Typescript 4.4.3

TypeScript 4.4 introduced a new compiler option called useUnknownInCatchVariables which is turned on if strict mode. Therefore, some test files are updated to satisfy the option.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners September 16, 2021 03:09
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #388 (59de304) into dev (255e6cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #388   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files          43       43           
  Lines        1798     1798           
  Branches      327      327           
=======================================
  Hits         1455     1455           
  Misses        342      342           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 255e6cc...59de304. Read the comment docs.

@bb111189 bb111189 merged commit 0c2a7f9 into dev Sep 16, 2021
@bb111189 bb111189 deleted the build/ts-v4 branch September 16, 2021 03:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use TypeScript v4
2 participants