Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

refactor(crypto): random #403

Merged
merged 2 commits into from
Sep 27, 2021
Merged

refactor(crypto): random #403

merged 2 commits into from
Sep 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2021

Description

This PR checks environments and includes tests for node.js, browser, and web worker.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from bb111189, renlulu and teye as code owners September 25, 2021 05:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #403 (f31bdda) into dev (76b5911) will increase coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head f31bdda differs from pull request most recent head 680853b. Consider uploading reports for the commit 680853b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #403      +/-   ##
==========================================
+ Coverage   80.89%   81.14%   +0.25%     
==========================================
  Files          43       43              
  Lines        1795     1798       +3     
  Branches      326      330       +4     
==========================================
+ Hits         1452     1459       +7     
+ Misses        342      338       -4     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/random.ts 95.65% <100.00%> (+20.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b5911...680853b. Read the comment docs.

@ghost ghost force-pushed the refactor/random branch from b432d0b to dc2d001 Compare September 26, 2021 05:11
@ghost ghost force-pushed the refactor/random branch 5 times, most recently from 362143d to 3fa9d0f Compare September 26, 2021 11:06
@ghost ghost force-pushed the refactor/random branch from 3fa9d0f to 680853b Compare September 27, 2021 01:43
@bb111189 bb111189 merged commit a15b935 into dev Sep 27, 2021
@bb111189 bb111189 deleted the refactor/random branch September 27, 2021 06:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants