Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

build: tslib as dependency #406

Merged
merged 3 commits into from
Sep 29, 2021
Merged

build: tslib as dependency #406

merged 3 commits into from
Sep 29, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 28, 2021 •
edited by ghost
Loading

Description

This PR adds tslib as dependency.
As of TypeScript 3.9, tslib version of 2.x is required to build new applications.

The tslib is a runtime library for Typescript. The version of this library is bound to the version of the TypeScript compiler used to compile a library. Peer dependencies do not accurately represent this relationship between the runtime and the compiler.
https://angular.io/guide/migration-update-libraries-tslib#why-is-this-migration-necessary

Users have been asked to install tslib since #169.

yarn add @zilliqa-js/zilliqa
# you may also need to install the tslib package.
yarn add tslib
# bn.js should be added with the above package. if it is not, install it manually.
yarn add bn.js

References:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost changed the title Build/tslib build: tslib as dependency Sep 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021 •
edited
Loading

Codecov Report

Merging #406 (3689d9e) into dev (96c014e) will not change coverage.
The diff coverage is n/a.

❗ Current head 3689d9e differs from pull request most recent head 48f49f0. Consider uploading reports for the commit 48f49f0 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #406   +/-   ##
=======================================
  Coverage   81.28%   81.28%           
=======================================
  Files          43       43           
  Lines        1811     1811           
  Branches      334      334           
=======================================
  Hits         1472     1472           
  Misses        338      338           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c014e...48f49f0. Read the comment docs.

@ghost ghost closed this Sep 28, 2021
@ghost ghost reopened this Sep 28, 2021
@bb111189 bb111189 merged commit 623b89f into dev Sep 29, 2021
@bb111189 bb111189 deleted the build/tslib branch September 29, 2021 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AmritKumar AmritKumar Awaiting requested review from AmritKumar

@snowsledge snowsledge Awaiting requested review from snowsledge

@renlulu renlulu Awaiting requested review from renlulu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @bb111189 @teye @Annihilatopia