Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

fix: elliptic ec signature type def #411

Merged
merged 3 commits into from
Oct 25, 2021
Merged

fix: elliptic ec signature type def #411

merged 3 commits into from
Oct 25, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2021 •
edited by ghost
Loading

Description

This PR closes #409 by using types/elliptic and require for elliptic/lib/elliptic/ec/signature

References:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners October 22, 2021 03:09
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021 •
edited
Loading

Codecov Report

Merging #411 (6752933) into dev (67115d0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #411   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          43       43           
  Lines        1811     1811           
  Branches      331      331           
=======================================
  Hits         1488     1488           
  Misses        322      322           
  Partials        1        1
Impacted Files Coverage Δ
...kages/zilliqa-js-account/src/transactionFactory.ts 96.29% <100.00%> (ø)
packages/zilliqa-js-account/src/wallet.ts 82.03% <100.00%> (ø)
packages/zilliqa-js-crypto/src/index.ts 100.00% <100.00%> (ø)
packages/zilliqa-js-crypto/src/schnorr.ts 87.20% <100.00%> (ø)
packages/zilliqa-js-crypto/src/util.ts 82.45% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67115d0...6752933. Read the comment docs.

@ghost ghost force-pushed the fix/elliptic-sig-type-def branch 2 times, most recently from 9c1aaea to a51dd98 Compare October 22, 2021 04:22
@ghost ghost force-pushed the fix/elliptic-sig-type-def branch from a51dd98 to 91f9080 Compare October 22, 2021 05:14
@ghost ghost force-pushed the fix/elliptic-sig-type-def branch from 91f9080 to e080a4f Compare October 22, 2021 06:40
@ghost
Copy link
Author

ghost commented Oct 22, 2021 •
edited by ghost
Loading

rebase

@ghost ghost force-pushed the fix/elliptic-sig-type-def branch from e080a4f to 6752933 Compare October 22, 2021 07:18
@ghost ghost mentioned this pull request Oct 22, 2021
Closed
@bb111189 bb111189 merged commit c9efd16 into dev Oct 25, 2021
@bb111189 bb111189 deleted the fix/elliptic-sig-type-def branch October 25, 2021 03:16
This was referenced Nov 8, 2021
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AmritKumar AmritKumar Awaiting requested review from AmritKumar

@renlulu renlulu Awaiting requested review from renlulu

@teye teye Awaiting requested review from teye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix type def for Elliptic Signature
2 participants
@codecov-commenter @bb111189