This repository was archived by the owner on May 26, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the TSC check in the CI.
For example the TSC check should fail for #424 which is the initial commit of #423. The TSC check doesn't fail for it because
when the build output is newly published to the local registry, the dependencies were not updated with the new version with
--canary
.Therefore, to fix the above issue this PR uses the following:
With this change, we can get the expected result: https://app.travis-ci.com/github/Zilliqa/Zilliqa-JavaScript-Library/builds/241400941#L909-L916.
Also, this PR changes the pre-commit hook to pre-push hook so that the husky hook can be skipped with
--no-push
.Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: