Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

ci: fix tsc check #425

Merged
merged 1 commit into from Nov 9, 2021
Merged

ci: fix tsc check #425

merged 1 commit into from Nov 9, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2021

Description

This PR fixes the TSC check in the CI.

For example the TSC check should fail for #424 which is the initial commit of #423. The TSC check doesn't fail for it because
when the build output is newly published to the local registry, the dependencies were not updated with the new version with --canary.

Therefore, to fix the above issue this PR uses the following:

npx lerna publish patch --registry $local_registry \
--no-verify-access --force-publish=* --no-push \
--ignore-scripts --dist-tag e2e --yes

With this change, we can get the expected result: https://app.travis-ci.com/github/Zilliqa/Zilliqa-JavaScript-Library/builds/241400941#L909-L916.

Also, this PR changes the pre-commit hook to pre-push hook so that the husky hook can be skipped with --no-push.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners November 8, 2021 23:41
@ghost ghost marked this pull request as draft November 8, 2021 23:42
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #425 (3220093) into dev (b973e4d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3220093 differs from pull request most recent head 0841f91. Consider uploading reports for the commit 0841f91 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #425   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          43       43           
  Lines        1811     1811           
  Branches      332      332           
=======================================
  Hits         1488     1488           
  Misses        322      322           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b973e4d...0841f91. Read the comment docs.

@ghost ghost marked this pull request as ready for review November 9, 2021 01:02
@bb111189 bb111189 merged commit 94eb831 into Zilliqa:dev Nov 9, 2021
@ghost ghost mentioned this pull request Nov 9, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants