Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

fix: signature replacement #427

Merged
merged 1 commit into from Nov 10, 2021
Merged

fix: signature replacement #427

merged 1 commit into from Nov 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2021

Description

This PR closes #422. This reverts #386 with modifications.

References:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners November 9, 2021 07:56
@ghost ghost marked this pull request as draft November 9, 2021 07:56
@ghost ghost closed this Nov 9, 2021
@ghost ghost reopened this Nov 9, 2021
@ghost ghost changed the title fix: d.ts for Signature fix: signature replacement Nov 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #427 (691c9ac) into dev (3c243fc) will increase coverage by 0.03%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #427      +/-   ##
==========================================
+ Coverage   82.12%   82.15%   +0.03%     
==========================================
  Files          43       44       +1     
  Lines        1807     1816       +9     
  Branches      332      334       +2     
==========================================
+ Hits         1484     1492       +8     
- Misses        322      323       +1     
  Partials        1        1              
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/signature.ts 88.88% <88.88%> (ø)
packages/zilliqa-js-crypto/src/index.ts 100.00% <100.00%> (ø)
packages/zilliqa-js-crypto/src/schnorr.ts 87.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c243fc...691c9ac. Read the comment docs.

@ghost ghost marked this pull request as ready for review November 9, 2021 10:34
@bb111189 bb111189 merged commit 17f8c7e into Zilliqa:dev Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@zilliqa-js/crypto doesn't build with vite due to using require with elliptic signature
2 participants