Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

fix: uuid #431

Merged
merged 1 commit into from
Nov 10, 2021
Merged

fix: uuid #431

merged 1 commit into from
Nov 10, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2021

Description

This PR uses import { v4 as uuidv4 } from 'uuid';
Also, it updates @types/uuid to v8.3.1

const uuid = require('uuid'); // <== REMOVED!
This usage pattern was already discouraged in [email protected] and has been removed in [email protected].

Reference:

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners November 10, 2021 09:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #431 (adcb760) into dev (5788e35) will not change coverage.
The diff coverage is 100.00%.

❗ Current head adcb760 differs from pull request most recent head 02d3df6. Consider uploading reports for the commit 02d3df6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #431   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files          44       44           
  Lines        1817     1817           
  Branches      335      335           
=======================================
  Hits         1493     1493           
  Misses        323      323           
  Partials        1        1           
Impacted Files Coverage Δ
packages/zilliqa-js-crypto/src/keystore.ts 92.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5788e35...02d3df6. Read the comment docs.

@bb111189 bb111189 merged commit 2f7ba77 into dev Nov 10, 2021
@bb111189 bb111189 deleted the fix/uuid branch November 10, 2021 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants