Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

ci: codecov #437

Merged
merged 1 commit into from
Feb 3, 2022
Merged

ci: codecov #437

merged 1 commit into from
Feb 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 28, 2022 •
edited by ghost
Loading

Description

This PR uses the new codecov uploader.

https://www.npmjs.com/package/codecov is being deprecated (February 1, 2022).

This uploader is being deprecated by the Codecov team. We recommend migrating to our new uploader as soon as possible to prevent any lapses in coverage. The new uploader is open source, and we highly encourage submitting Issues and Pull Requests.

You can visit our blog post to learn more about our deprecation plan

On February 1, 2022 this uploader will be completely deprecated and will no longer be able to upload coverage to Codecov.

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners January 28, 2022 19:45
@ghost ghost force-pushed the ci/codecov branch 2 times, most recently from c8576fb to d7c03f5 Compare January 28, 2022 20:16
@ghost ghost requested review from renlulu and teye as code owners January 28, 2022 20:16
@ghost ghost marked this pull request as draft January 28, 2022 20:30
@ghost ghost force-pushed the ci/codecov branch 3 times, most recently from e98630d to 8b72f8c Compare January 29, 2022 00:31
@ghost ghost marked this pull request as ready for review January 30, 2022 04:29
@ghost
Copy link
Author

ghost commented Jan 30, 2022 •
edited by ghost
Loading

We need to update the new CODECOV_TOKEN in the travis CI for this repo.
The new CODECOV_TOKEN should be visible in https://app.codecov.io/gh/Zilliqa/zilliqa-js

I don’t have the access to see a new CODECOV_TOKEN for the this repo in the codecov.
Can you help me with this?

@ghost ghost force-pushed the ci/codecov branch from 8b72f8c to 45bbe8c Compare February 3, 2022 07:08
@ghost ghost requested a review from bb111189 February 3, 2022 07:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #437 (45bbe8c) into dev (ed7704d) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #437      +/-   ##
==========================================
- Coverage   82.16%   82.12%   -0.05%     
==========================================
  Files          44       44              
  Lines        1817     1818       +1     
  Branches      335      335              
==========================================
  Hits         1493     1493              
- Misses        323      325       +2     
+ Partials        1        0       -1
Impacted Files Coverage Δ
...kages/zilliqa-js-account/src/transactionFactory.ts 92.59% <0.00%> (-3.71%) ⬇️
packages/zilliqa-js-blockchain/src/util.ts 83.33% <0.00%> (ø)
packages/zilliqa-js-crypto/src/random.ts 95.23% <0.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed7704d...45bbe8c. Read the comment docs.

@bb111189 bb111189 merged commit aee10d6 into dev Feb 3, 2022
@bb111189 bb111189 deleted the ci/codecov branch February 3, 2022 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AmritKumar AmritKumar Awaiting requested review from AmritKumar

@renlulu renlulu Awaiting requested review from renlulu

@teye teye Awaiting requested review from teye

@bb111189 bb111189 Awaiting requested review from bb111189

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codecov-commenter @bb111189