Fix the flaky test provider in LiveBackupTests. - #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky live backup unit test by making the test backup provider match the
ILiveBackupStoreconcurrency contract.What Changed
CatalogTrackingLiveBackupProviderthread-safe by locking access to its uploaded-file catalog.SegmentIdtoFileName, so the fake provider tracks physical segment files the same way the real local backup provider does.Why
LiveBackupmay callUseSegmentAsyncandUploadSegmentFileAsyncconcurrently because segment files are copied withParallel.ForEachAsync. The test provider used a plainHashSetwithout synchronization, which could race in CI and incorrectly report that previously uploaded files were missing.