.NET 8.0 support via Backport.System.Threading.Lock - #172
Closed
berik-99 wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds .NET 8 (LTS) compatibility to ZoneTree by multi-targeting the main library and unit tests, while preserving System.Threading.Lock-style optimizations via an analyzer/source-generator backport without introducing runtime dependencies.
Changes:
- Multi-target
ZoneTreelibrary to includenet8.0. - Add
Backport.System.Threading.Lockas an analyzer fornet8.0builds. - Update the unit test project to multi-target and apply the analyzer for
net8.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ZoneTree/ZoneTree.csproj | Adds net8.0 target framework and conditionally includes the lock backport analyzer for net8.0. |
| src/ZoneTree.UnitTests/ZoneTree.UnitTests.csproj | Multi-targets tests and conditionally includes the lock backport analyzer for net8.0 (but currently misses net9.0). |
| src/ZoneTree.UnitTests/BottomSegmentMergeTests.cs | Minor test code tweak (queue initialization) and using cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Member
|
Thank you for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for .NET 8.0 across the library and test projects to ensure full compatibility with the current Long Term Support (LTS) release, which remains actively supported and widely used in production.
To maintain System.Threading.Lock optimizations without introducing runtime dependencies, the Backport.System.Threading.Lock source generator has been integrated.
Summary of Changes
net8.0to the target frameworks in the main library.csproj.Backport.System.Threading.Lockas an analyzer/source generator, enabling modern locking patterns across supported target frameworks without adding external runtime package dependencies.Testing