Adds bounded retry/backoff around LocalFileStreamProvider.Replace to handle transient File.Replace failures on Windows - #174
Merged
Conversation
…o handle transient `File.Replace` failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds bounded retry/backoff around
LocalFileStreamProvider.Replaceto handle transientFile.Replacefailures on Windows, such as watcher-related interference from tools like editors or file indexers.The implementation preserves ZoneTree’s existing atomic replacement behavior by continuing to use
File.Replace; it only retries transientIOExceptions before surfacing the original failure.Changes
File.Replaceon retryableIOExceptions with short bounded backoff delays:10ms,25ms,50ms,100ms,200ms.FileNotFoundExceptionDirectoryNotFoundExceptionDriveNotFoundExceptionPathTooLongExceptionMotivation
On Windows,
File.Replacemay fail transiently with errors like “Unable to remove the file to be replaced” when another process has aFileSystemWatcheractive on the directory. Retrying briefly handles that interference without replacing the atomic operation with a less durable delete/move fallback.