feat(review): add scoring rubrics, score justification, and challenge response protocol#2
Merged
Merged
Conversation
… response protocol Add transparent scoring system to all 5 review templates and quality targets to 2 generation templates. Review templates (review-spec, review-plan, review-tasks, review-python-code, review-react-code): - Scoring Rubrics with score ranges and typical deductions per category - Enhanced Scoring Breakdown with Rubric Basis and Deduction Details columns - Suggestion Score Cap limiting suggestions to max 5 points impact - Score Validation Checklist for arithmetic and consistency verification - Score Challenge Response Protocol for objective 3-step dispute handling Generation templates (spec-to-plan, plan-to-tasks): - Quality Targets section aligned with corresponding review rubric categories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses core user feedback about opaque and inconsistent review scoring by adding transparent scoring rubrics to all 5 review templates, and quality targets to 2 generation
templates. Users can now trace every score to specific rubric criteria and deduction details, and the system handles score challenges objectively through a defined 3-step protocol.
Changes
Key Modifications
templates/commands/review-spec.mdtemplates/commands/review-plan.mdtemplates/commands/review-tasks.mdtemplates/commands/review-python-code.mdtemplates/commands/review-react-code.mdtemplates/commands/spec-to-plan.mdtemplates/commands/plan-to-tasks.md.claude-plugin/marketplace.jsonTechnical Details
Review Templates (5 files) — Each template now includes:
Generation Templates (2 files) — Each template now includes:
Testing
Test Coverage:
How to Verify
git checkout 2026-0409-1149ob-enhance-review-qualitytemplates/commands/review-spec.md) and verify:spec-to-plan.md,plan-to-tasks.md) for "Quality Targets" sectionuv tool install --force ./codexspec:review-spec) on a sample spec to verify the new sections appear in the reportChecklist
templates/commands/modified (per constitution)Notes
language.outputconfiguration continues to work — all new sections are in English templates but will be dynamically translated by Claude at runtime