fix: replace anyio.Lock with asyncio.Lock to resolve lock handling issues #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this happens, then something else is being done wrong. Simply bypassing such checks isn't going to fix the root issue. |
|
I fixed this in #1879 it required opening the exit_stack for streaming request inside the streaming response handler. This prevents the attempting at trying to close it from a different task in which it was opened. It required a larger refactor to correct the issue |
|
Superseded by #1879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1861
Using
llama_cpp.serverwith"stream": trueparameter resulted inRuntimeError: The current task is not holding this lockerror.Using
asyncio.Lock()instead ofanyio.Lock()fixes this error.