Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve package datafile handlers #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

Improve package datafile handlers #3873

merged 1 commit into from
Nov 14, 2024

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Jul 25, 2024 •
edited by AyanSinhaMahapatra
Loading

  • Add new attributes to the DatafileHandler class for a datasource type and the support operating systems
  • Add and test new validate() method to validate DatafileHandler collection correctness
  • Apply minor refactorings and code formatting

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@pombredanne pombredanne mentioned this pull request Aug 7, 2024
Open
@pombredanne
Improve package datafile handlers
b1cef69 
* Add new attributes to the DatafileHandler class for a datasource type
  and the supported operating systems
* Add and test new validate() method to validate DatafileHandler
  collection correctness
* Apply minor refactorings and code formatting

Signed-off-by: Philippe Ombredanne <[email protected]>
AyanSinhaMahapatra
AyanSinhaMahapatra approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @pombredanne
Merging this!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 65e1c2d into develop Nov 14, 2024
33 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the refine-handlers branch November 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pombredanne @AyanSinhaMahapatra