Implement FR #3142: Add local recycle bin or trash folder option #3168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial implementation commit of FR #3142 to implement moving files to a configured 'Recycle Bin' rather than a hard delete.
This comment has been minimized.
This comment has been minimized.
* Add trashinfo
* Add documentation for feature
* Update doc
This comment has been minimized.
This comment has been minimized.
* Correct typo
* Update code to align to actual GNOME / KDE deletion
* Update documentation, add that this capability is designed to be compatible with the FreeDesktop.org Trash Specification
* Add new option to 'config' file for reference
* Ensure when configuring 'recycleBinFilePath' and 'recycleBinInfoPath' that the basePath has a trailing '/' to ensure these paths are built correctly
* Update documentation
* Update PR to process online deletions in non-reverse order, thus preserving data in folders when moved locally * Fix issue where 'skip_file' was falsely being triggered when adding|removing 'use_recycle_bin' option
Owner
Author
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Repository owner
locked and limited conversation to collaborators
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements Feature Request #3142 by introducing a configurable local recycle bin or trash folder mechanism within the OneDrive Client for Linux. This enhancement provides users with a safeguard against unintended data loss during synchronisation operations. This capability is designed to be compatible with the FreeDesktop.org Trash Specification.
Key Features:
Configurable Recycle Bin Directory: Users can specify a local directory to serve as a recycle bin using the
--recycle-binoption. Files that would otherwise be deleted during sync operations are moved to this directory instead of being permanently removed.Integration with Sync Operations: The recycle bin feature integrates seamlessly with existing operational usage modes. It ensures that file deletions during these operations respect the recycle bin settings.
Logging and Transparency: Actions related to the recycle bin, such as moving files and purging old items, are logged to provide users with clear visibility into the client's operations.