Minor: gitignore consistency #3188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles generated from .in templates
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (41)To accept these unrecognized words as correct, you could run the following commands... in a clone of the [email protected]:Romadelf/onedrive.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/abraunegg/onedrive/actions/runs/14161607913/attempts/1'
|
Owner
|
@Romadelf Please also read: check-spelling/check-spelling#90 (comment) |
Contributor
Author
|
Alright, the maintainer has answered here. What do you prefer to do now:
Note: I'm fine if you hard-delete #3187 as it is no longer relevant and this #3188 is now more concise. I removed the old PR reference in the top comment accordingly. |
Owner
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Repository owner
locked and limited conversation to collaborators
Apr 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring files created during configure to be consistent with other files generated from
.intemplatesDuring a
./configurerun, files are being created from templates using user specific configuration. Most of them are correctly ignored. But somehow,contrib/systemd/[email protected]andcontrib/systemd/onedrive.servicewere left behind and most probably forgotten.Unless I am mistaken, this commit is a safe minor improvement for the dev side as, with it, these files do not need to be deleted manually anymore before making commits to a forked repo. Needs review.