chore: more ruff checks enabled#285
Merged
abravalheri merged 2 commits intoNov 27, 2025
Merged
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
abravalheri
approved these changes
Nov 27, 2025
Owner
abravalheri
left a comment
There was a problem hiding this comment.
Thank you very much @henryiii
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables more ruff checks (most of the ones recommended by
uvx --from sp-repo-review[cli] sp-ruff-checks .). I've ignored rather than fixed anything that might be at all risky, but some of those probably should be addressed at some point (mostly unused arguments).Automatic fixes:
Manual fixes and ignores: