Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add fail-on-error input to fail workflow on cache save errors#1749

Open
Mordil wants to merge 1 commit into
actions:mainfrom
Mordil:nh-fail-on-save-error
Open

Add fail-on-error input to fail workflow on cache save errors#1749
Mordil wants to merge 1 commit into
actions:mainfrom
Mordil:nh-fail-on-save-error

Conversation

@Mordil
Copy link
Copy Markdown

@Mordil Mordil commented Apr 17, 2026

Description

  • Add: fail-on-error input to save action
  • Add: fail-on-save-error input to cache action
  • Change: saveImpl to mark the job failed if an error is encountered and the inputs are specified

Motivation and Context

Resolves #1581, #1189, and possibly more.

This action is failing silently and does not provide any control to users to NOT behave this way, much like is available for the restore action.

This brings parity & control, in a backwards compatible way.

How Has This Been Tested?

Tests were added for these conditions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Mordil Mordil requested a review from a team as a code owner April 17, 2026 19:04
@asperpharma
Copy link
Copy Markdown

Mordil:nh-fail-on-save-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

actions/cache/save does not fail the step on error

2 participants