-
Notifications
You must be signed in to change notification settings - Fork 140
Add explicit permissions to workflow files #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances security by adding explicit permissions to GitHub workflow files and expanding CodeQL analysis coverage. The changes address security findings by implementing least-privilege access controls and ensuring Ruby code is included in security scans.
- Added explicit
contents: read
permissions to CI and check-dist workflows
- Extended CodeQL analysis to include Ruby language support
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/ci.yml |
Added explicit read-only contents permission |
.github/workflows/check-dist.yml |
Added explicit read-only contents permission |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Because of this security finding I had added |
…3 [skip ci] Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.7.2 to 4.7.3. Release notes *Sourced from [actions/dependency-review-action's releases](https://github.com/actions/dependency-review-action/releases).* > 4.7.3 > ----- > > What's Changed > -------------- > > * Add explicit permissions to workflow files by [`@AshelyTC`](https://github.com/AshelyTC) in [actions/dependency-review-action#966](https://redirect.github.com/actions/dependency-review-action/pull/966) > * Claire153/fix spamming mentioned issue by [`@claire153`](https://github.com/claire153) in [actions/dependency-review-action#974](https://redirect.github.com/actions/dependency-review-action/pull/974) > > **Full Changelog**: <actions/dependency-review-action@v4...v4.7.3> Commits * [`595b5ae`](actions/dependency-review-action@595b5ae) Update package version ([#975](https://redirect.github.com/actions/dependency-review-action/issues/975)) * [`fc5fd66`](actions/dependency-review-action@fc5fd66) Claire153/fix spamming mentioned issue ([#974](https://redirect.github.com/actions/dependency-review-action/issues/974)) * [`d38d1a4`](actions/dependency-review-action@d38d1a4) Merge pull request [#965](https://redirect.github.com/actions/dependency-review-action/issues/965) from actions/dependabot/npm\_and\_yarn/multi-c22e25d29b * [`8d420b8`](actions/dependency-review-action@8d420b8) Merge branch 'main' into dependabot/npm\_and\_yarn/multi-c22e25d29b * [`bde0129`](actions/dependency-review-action@bde0129) Merge pull request [#966](https://redirect.github.com/actions/dependency-review-action/issues/966) from actions/ashelytc/add-permissions * [`ab52490`](actions/dependency-review-action@ab52490) remove ruby * [`ef00a0a`](actions/dependency-review-action@ef00a0a) add permissions to workflows * [`74c8179`](actions/dependency-review-action@74c8179) Bump brace-expansion * See full diff in [compare view](actions/dependency-review-action@bc41886...595b5ae) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
…3 [skip ci] Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.7.2 to 4.7.3. Release notes *Sourced from [actions/dependency-review-action's releases](https://github.com/actions/dependency-review-action/releases).* > 4.7.3 > ----- > > What's Changed > -------------- > > * Add explicit permissions to workflow files by [`@AshelyTC`](https://github.com/AshelyTC) in [actions/dependency-review-action#966](https://redirect.github.com/actions/dependency-review-action/pull/966) > * Claire153/fix spamming mentioned issue by [`@claire153`](https://github.com/claire153) in [actions/dependency-review-action#974](https://redirect.github.com/actions/dependency-review-action/pull/974) > > **Full Changelog**: <actions/dependency-review-action@v4...v4.7.3> Commits * [`595b5ae`](actions/dependency-review-action@595b5ae) Update package version ([#975](https://redirect.github.com/actions/dependency-review-action/issues/975)) * [`fc5fd66`](actions/dependency-review-action@fc5fd66) Claire153/fix spamming mentioned issue ([#974](https://redirect.github.com/actions/dependency-review-action/issues/974)) * [`d38d1a4`](actions/dependency-review-action@d38d1a4) Merge pull request [#965](https://redirect.github.com/actions/dependency-review-action/issues/965) from actions/dependabot/npm\_and\_yarn/multi-c22e25d29b * [`8d420b8`](actions/dependency-review-action@8d420b8) Merge branch 'main' into dependabot/npm\_and\_yarn/multi-c22e25d29b * [`bde0129`](actions/dependency-review-action@bde0129) Merge pull request [#966](https://redirect.github.com/actions/dependency-review-action/issues/966) from actions/ashelytc/add-permissions * [`ab52490`](actions/dependency-review-action@ab52490) remove ruby * [`ef00a0a`](actions/dependency-review-action@ef00a0a) add permissions to workflows * [`74c8179`](actions/dependency-review-action@74c8179) Bump brace-expansion * See full diff in [compare view](actions/dependency-review-action@bc41886...595b5ae) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Addresses these security findings:
TLDR; This PR adds missing explicit permissions to the workflow files.