Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

claire153
Copy link
Contributor

@claire153 claire153 commented Aug 26, 2025

Closes #973

Remove the URL of the mentioned issue in the deprecation message, as it was linking any PR running the action to that mentioned issue.
Instead, only keep the issue number.

I will cut a new release after this PR is merged.

@claire153 claire153 marked this pull request as ready for review August 26, 2025 19:22
@Copilot Copilot AI review requested due to automatic review settings August 26, 2025 19:22
@claire153 claire153 requested a review from a team as a code owner August 26, 2025 19:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where deprecation warnings were creating unwanted mentions and links to GitHub issues in PR comments. The change removes the full URL from the deprecation message for the deny-licenses option, keeping only the issue number to avoid spamming the referenced issue.

Key Changes:

  • Modified deprecation warning message to use plain text instead of markdown link
  • Added moment dependency to package.json
  • Updated workflow to test the deprecated deny-licenses option

Reviewed Changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

File Description
src/summary.ts Removed markdown link from deprecation warning to prevent issue mentions
package.json Added moment dependency
.github/workflows/dependency-review.yml Added deny-licenses configuration to test deprecated functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@dangoor dangoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@claire153 claire153 merged commit fc5fd66 into main Aug 26, 2025
7 checks passed
@claire153 claire153 deleted the claire153/fix-spamming-mentioned-issue branch August 26, 2025 19:46
mergify bot added a commit to ArcadeData/arcadedb that referenced this pull request Aug 31, 2025
…3 [skip ci]

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.7.2 to 4.7.3.
Release notes

*Sourced from [actions/dependency-review-action's releases](https://github.com/actions/dependency-review-action/releases).*

> 4.7.3
> -----
>
> What's Changed
> --------------
>
> * Add explicit permissions to workflow files by [`@​AshelyTC`](https://github.com/AshelyTC) in [actions/dependency-review-action#966](https://redirect.github.com/actions/dependency-review-action/pull/966)
> * Claire153/fix spamming mentioned issue by [`@​claire153`](https://github.com/claire153) in [actions/dependency-review-action#974](https://redirect.github.com/actions/dependency-review-action/pull/974)
>
> **Full Changelog**: <actions/dependency-review-action@v4...v4.7.3>


Commits

* [`595b5ae`](actions/dependency-review-action@595b5ae) Update package version ([#975](https://redirect.github.com/actions/dependency-review-action/issues/975))
* [`fc5fd66`](actions/dependency-review-action@fc5fd66) Claire153/fix spamming mentioned issue ([#974](https://redirect.github.com/actions/dependency-review-action/issues/974))
* [`d38d1a4`](actions/dependency-review-action@d38d1a4) Merge pull request [#965](https://redirect.github.com/actions/dependency-review-action/issues/965) from actions/dependabot/npm\_and\_yarn/multi-c22e25d29b
* [`8d420b8`](actions/dependency-review-action@8d420b8) Merge branch 'main' into dependabot/npm\_and\_yarn/multi-c22e25d29b
* [`bde0129`](actions/dependency-review-action@bde0129) Merge pull request [#966](https://redirect.github.com/actions/dependency-review-action/issues/966) from actions/ashelytc/add-permissions
* [`ab52490`](actions/dependency-review-action@ab52490) remove ruby
* [`ef00a0a`](actions/dependency-review-action@ef00a0a) add permissions to workflows
* [`74c8179`](actions/dependency-review-action@74c8179) Bump brace-expansion
* See full diff in [compare view](actions/dependency-review-action@bc41886...595b5ae)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/dependency-review-action&package-manager=github\_actions&previous-version=4.7.2&new-version=4.7.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mergify bot added a commit to ArcadeData/arcadedb that referenced this pull request Sep 14, 2025
…3 [skip ci]

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.7.2 to 4.7.3.
Release notes

*Sourced from [actions/dependency-review-action's releases](https://github.com/actions/dependency-review-action/releases).*

> 4.7.3
> -----
>
> What's Changed
> --------------
>
> * Add explicit permissions to workflow files by [`@​AshelyTC`](https://github.com/AshelyTC) in [actions/dependency-review-action#966](https://redirect.github.com/actions/dependency-review-action/pull/966)
> * Claire153/fix spamming mentioned issue by [`@​claire153`](https://github.com/claire153) in [actions/dependency-review-action#974](https://redirect.github.com/actions/dependency-review-action/pull/974)
>
> **Full Changelog**: <actions/dependency-review-action@v4...v4.7.3>


Commits

* [`595b5ae`](actions/dependency-review-action@595b5ae) Update package version ([#975](https://redirect.github.com/actions/dependency-review-action/issues/975))
* [`fc5fd66`](actions/dependency-review-action@fc5fd66) Claire153/fix spamming mentioned issue ([#974](https://redirect.github.com/actions/dependency-review-action/issues/974))
* [`d38d1a4`](actions/dependency-review-action@d38d1a4) Merge pull request [#965](https://redirect.github.com/actions/dependency-review-action/issues/965) from actions/dependabot/npm\_and\_yarn/multi-c22e25d29b
* [`8d420b8`](actions/dependency-review-action@8d420b8) Merge branch 'main' into dependabot/npm\_and\_yarn/multi-c22e25d29b
* [`bde0129`](actions/dependency-review-action@bde0129) Merge pull request [#966](https://redirect.github.com/actions/dependency-review-action/issues/966) from actions/ashelytc/add-permissions
* [`ab52490`](actions/dependency-review-action@ab52490) remove ruby
* [`ef00a0a`](actions/dependency-review-action@ef00a0a) add permissions to workflows
* [`74c8179`](actions/dependency-review-action@74c8179) Bump brace-expansion
* See full diff in [compare view](actions/dependency-review-action@bc41886...595b5ae)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/dependency-review-action&package-manager=github\_actions&previous-version=4.7.2&new-version=4.7.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Don't include the full URL to the issue in the deprecation warning
2 participants