Fix deploy-pages@v4 #287
Closed
Fix deploy-pages@v4 #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
referenced
this pull request
in process-analytics/bpmn-visualization-addons
Dec 20, 2023
Also bump actions/upload-pages-artifact from 2 to 3, because this version of actions/deploy-pages is ONLY compatible with artifacts uploaded by actions/upload-pages-artifact@v3 or newer.
|
We appreciate your contribution but this is not the change that we need or want moving forward. We have a change in progress on the GitHub API side to clear a blocker up, plus a forthcoming PR with #288 that will alleviate the need for adding the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can potentially fix #284, fix #285, and fix #286. However, we need some help from GitHub employee as well (see below).
The current API of
POST /repos/{owner}/{repo}/pages/deployment(doc) does not takeartifact_idparameter, that it would only takeartifact_url. @TooManyBees I'm not sure if this is intended for an unreleased upcoming version of the API, or it was an oversight.Although this PR updates the code to provide the right download url for artifact v4 as the
artifact_urlparameter, now we're running into anInvalid artifact urlerror. This is likely due to the new hostnames in artifact v4 urls are not whitelisted in the/pages/deploymentAPI. We probably need a GitHub employee to fix this:@JamesMGreene Pinging you as it seems that you might be the right person to help resolve the
Invalid artifact urlerror based on similar issues in the past.