Remove octokit README updates for v7
#557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello from actions/github-script! (f048dc3) |
robherley
approved these changes
Feb 26, 2025
|
I dont understand why #508 was a breaking change if it didnt remove any functionality and didnt change existing, it only added to the api surface. Can someone elaborate? |
If users are defining a variable named For example: - uses: actions/github-script@main
with:
script: |
const octokit = github
await octokit.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: ${{ github.event.issue.number }},
body: "Hello Again!"
})That will fail with the error https://github.com/joshmgross/actions-testing/actions/runs/13551951964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
octokitinstance from README examples doesn't work #545#508 introduced a new
octokitvariable to make it easier to use examples from GitHub and Octokit docs withinactions/github-script.That change is a breaking change so the README updates shouldn't have been made with v7.
We'll update the README to include this info again when we're ready for v8 - #556