Thanks to visit codestin.com
Credit goes to github.com

Skip to content

When upgrading pip, don't warn there's a new version of pip available #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2021
Merged

When upgrading pip, don't warn there's a new version of pip available #117

merged 1 commit into from
Oct 18, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 10, 2021 •
edited
Loading

Fixes actions/setup-python#233.

I often see "errors" like this when testing Python 3.10:

image
https://github.com/bridgecrewio/checkov/actions/runs/1325650057

WARNING: You are using pip version 21.2.3; however, version 21.2.4 is available. You should consider upgrading via the '/opt/hostedtoolcache/Python/3.10.0/x64/bin/python -m pip install --upgrade pip' command.

Several problems here:

  • It's a warning, but shown as an error ("2 errors" in screenshot). 

  • The "error" doesn't fail the build (this is actually a good thing, but still confusing).

  • There's nothing I can actually do about this, it happens during actions/setup-python.

  • False warnings mean people start to ignore real warnings.

  • And ironically it warns to upgrade pip at the same time it is actually upgrading pip!

Let's disable the warning/error using:

  --disable-pip-version-check
                              Don't periodically check PyPI to determine whether a new version of pip is available for
                              download. Implied with --no-index.

Local test, first install an old version and then test the install command:

Before

$ python -m pip install pip==21.2.3

Collecting pip==21.2.3
  Using cached pip-21.2.3-py3-none-any.whl (1.6 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 21.2.4
    Uninstalling pip-21.2.4:
      Successfully uninstalled pip-21.2.4
Successfully installed pip-21.2.3
$ python -m pip install --ignore-installed pip --no-warn-script-location
Collecting pip
  Using cached pip-21.2.4-py3-none-any.whl (1.6 MB)
Installing collected packages: pip
Successfully installed pip-21.2.4
WARNING: You are using pip version 21.2.3; however, version 21.2.4 is available.
You should consider upgrading via the '/Library/Frameworks/Python.framework/Versions/3.9/bin/python3 -m pip install --upgrade pip' command.

After

$ python -m pip install pip==21.2.3

Collecting pip==21.2.3
  Using cached pip-21.2.3-py3-none-any.whl (1.6 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 21.2.4
    Uninstalling pip-21.2.4:
      Successfully uninstalled pip-21.2.4
Successfully installed pip-21.2.3
$ python -m pip install --ignore-installed pip --disable-pip-version-check --no-warn-script-location
Collecting pip
  Using cached pip-21.2.4-py3-none-any.whl (1.6 MB)
Installing collected packages: pip
Successfully installed pip-21.2.4

@hugovk hugovk mentioned this pull request Oct 10, 2021
Closed
7 tasks
@dibir-magomedsaygitov dibir-magomedsaygitov requested a review from a team October 11, 2021 06:56
@umarcor
Copy link

umarcor commented Oct 17, 2021

Can some maintainer please approve workflow execution in this PR?

@MaksimZhukov MaksimZhukov merged commit 641a276 into actions:main Oct 18, 2021
@MaksimZhukov
Copy link
Contributor

Hello @hugovk ! Thank you for the contribution!
We will rebuild Python versions soon.

@hugovk hugovk deleted the dont-warn-pip-upgrade-when-upgrading-pip branch October 18, 2021 11:38
@hugovk hugovk mentioned this pull request Oct 18, 2021
Closed
8 tasks
@MaksimZhukov MaksimZhukov mentioned this pull request Oct 19, 2021
Merged
@nikita-bykov
Copy link

We've successfully rebuilt the following Python versions:

  • 3.11.0-alpha.1
  • 3.10.0
  • 3.9.6
  • 3.8.12
  • 3.8.10
  • 3.8.6

@Jpsern Jpsern mentioned this pull request Dec 1, 2021
Merged
@jugmac00
Copy link

Hugo pointed me to this issue today, as I encountered this problem in a CI run for Python3.5-based project.

I know I know, while Python 3.5 is eol upstream, distros still support it for years to come.

@jugmac00 jugmac00 mentioned this pull request Jun 27, 2022
Merged
@dmitry-shibanov dmitry-shibanov mentioned this pull request Nov 21, 2022
Closed
5 tasks
@dirkf dirkf mentioned this pull request Apr 6, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
5 more reviewers

@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes

@umarcor umarcor umarcor approved these changes

@MaksimZhukov MaksimZhukov MaksimZhukov approved these changes

@al-cheb al-cheb al-cheb approved these changes

@miketimofeev miketimofeev miketimofeev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting communication about pip versions in action output
8 participants
@hugovk @umarcor @MaksimZhukov @nikita-bykov @jugmac00 @dmitry-shibanov @al-cheb @miketimofeev