Update dependencies to latest versions for hashfiles#1756
Merged
Conversation
thboop
commented
Mar 15, 2022
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "plugins": ["jest", "@typescript-eslint"], | |||
| "extends": ["plugin:github/es6"], | |||
thboop
commented
Mar 15, 2022
| "@typescript-eslint/array-type": "error", | ||
| "@typescript-eslint/await-thenable": "error", | ||
| "@typescript-eslint/ban-ts-ignore": "error", | ||
| "@typescript-eslint/naming-convention": [ |
Collaborator
Author
There was a problem hiding this comment.
This replaces
"@typescript-eslint/camelcase": "error",
"@typescript-eslint/class-name-casing": "error",
thboop
commented
Mar 15, 2022
| "@typescript-eslint/unbound-method": "error" | ||
| "@typescript-eslint/unbound-method": "error", | ||
| "filenames/match-regex" : "off", | ||
| "github/no-then" : 1, // warning |
Collaborator
Author
There was a problem hiding this comment.
new rules introduced, we fail this one, lets warn for now and if we want to update the code later we can
thboop
commented
Mar 15, 2022
| "@typescript-eslint/type-annotation-spacing": "error", | ||
| "@typescript-eslint/unbound-method": "error" | ||
| "@typescript-eslint/unbound-method": "error", | ||
| "filenames/match-regex" : "off", |
Collaborator
Author
There was a problem hiding this comment.
this provides a regex that all filesnames must match, the project is one file, lets just turn it off.
thboop
commented
Mar 15, 2022
| "@typescript-eslint/class-name-casing": "error", | ||
| "@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}], | ||
| "@typescript-eslint/func-call-spacing": ["error", "never"], | ||
| "@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"], |
Collaborator
Author
There was a problem hiding this comment.
I removed some depreciated rules, again this is a one file project, I think we are okay without heavy linting.
"@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
"@typescript-eslint/no-object-literal-type-assertion": "error",
"@typescript-eslint/prefer-interface": "error",
thboop
commented
Mar 15, 2022
| import * as glob from '@actions/glob' | ||
| import * as crypto from 'crypto' | ||
| import * as fs from 'fs' | ||
| import * as glob from '@actions/glob' |
Collaborator
Author
There was a problem hiding this comment.
reordered due to new rule expecting imports to be in alphabetical order
thboop
commented
Mar 15, 2022
| const glob = __importStar(__webpack_require__(281)); | ||
| const crypto = __importStar(__webpack_require__(417)); | ||
| const fs = __importStar(__webpack_require__(747)); | ||
| const glob = __importStar(__webpack_require__(281)); |
Collaborator
Author
There was a problem hiding this comment.
no changes besides the order of imports being moved around
TingluoHuang
approved these changes
Mar 18, 2022
thboop
added a commit
that referenced
this pull request
Mar 18, 2022
thboop
added a commit
that referenced
this pull request
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: