Cleanup feature flag actions_container_action_runner_temp#4163
Cleanup feature flag actions_container_action_runner_temp#4163ericsciple merged 1 commit intomainfrom
Conversation
…emp for container actions
There was a problem hiding this comment.
Pull request overview
This PR removes the ContainerActionRunnerTemp feature flag and makes the runner temp directory mounting behavior permanent for container actions. The feature flag previously controlled whether the runner temp directory would be mounted and path-translated in container actions.
Key Changes
- Unconditionally mount
/github/runner_tempvolume in container actions without checking the feature flag - Remove the
IsContainerActionRunnerTempEnabledmethod from FeatureManager - Remove the
ContainerActionRunnerTempconstant from the Features class
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Runner.Worker/Handlers/ContainerActionHandler.cs | Removed conditional checks for the feature flag, making runner_temp volume mounting and path translation permanent |
| src/Runner.Worker/FeatureManager.cs | Removed the IsContainerActionRunnerTempEnabled method that checked the feature flag |
| src/Runner.Common/Constants.cs | Removed the ContainerActionRunnerTemp feature flag constant and some trailing whitespace |
|
|
||
| // Node version migration related constants | ||
| public static class NodeMigration | ||
| { | ||
| // Node versions | ||
| public static readonly string Node20 = "node20"; | ||
| public static readonly string Node24 = "node24"; | ||
|
|
||
| // Environment variables for controlling node version selection | ||
| public static readonly string ForceNode24Variable = "FORCE_JAVASCRIPT_ACTIONS_TO_NODE24"; | ||
| public static readonly string AllowUnsecureNodeVersionVariable = "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION"; | ||
|
|
There was a problem hiding this comment.
These whitespace-only changes appear to be unintentional. The trailing whitespace has been removed from empty lines in the NodeMigration section, which is unrelated to the feature flag removal. Consider reverting these whitespace changes to keep this PR focused on the ContainerActionRunnerTemp feature flag removal, or if this is intentional code formatting, it should be applied consistently across the entire file.
Related to container action support for actions/checkout@v6 on GHES