Allow hosted VM report job telemetry via .setup_info file.#4186
Allow hosted VM report job telemetry via .setup_info file.#4186TingluoHuang merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enables hosted VMs to report job telemetry by filtering internal setup information groups. Internal groups (prefixed with "internal") are now captured as telemetry data instead of being displayed in job output, allowing hosted infrastructure to report telemetry without exposing internal details to end users.
- Adds filtering logic to detect internal groups in the .setup_info file
- Routes internal group information to JobTelemetry for backend processing
- Maintains existing behavior for non-internal groups
| // not output internal groups | ||
| if (groupName.StartsWith("_internal_", StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| jobContext.Global.JobTelemetry.Add(new JobTelemetry() { Type = JobTelemetryType.General, Message = info.Detail }); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This new behavior of filtering internal groups and sending them as telemetry should be protected by a feature flag. According to the custom coding guidelines, all changes should be safeguarded by feature flags wherever possible. Feature flags should be declared in Constants.cs under the Features class. Consider adding a feature flag check before implementing this new filtering logic to allow for controlled rollout and easy rollback if issues are discovered.
https://github.com/github/hosted-compute/issues/3871