Validate inputs only for repo action, no warning for small delay.#476
Merged
Conversation
TingluoHuang
commented
May 12, 2020
|
|
||
| foreach (var input in userInputs) | ||
| // Validate inputs only for actions with action.yml | ||
| if (Action.Reference.Type == Pipelines.ActionSourceType.Repository) |
Member
Author
There was a problem hiding this comment.
The real diff is:
if (Action.Reference.Type == Pipelines.ActionSourceType.Repository)
{
existing code
}
Member
Author
There was a problem hiding this comment.
the current cause unwanted warning for run step.
ex: https://github.com/actions/canary/actions/runs/102763474
Collaborator
There was a problem hiding this comment.
cool, basically anyhting with action.yml
ericsciple
reviewed
May 12, 2020
|
|
||
| // report total delay caused by server throttling. | ||
| if (_totalThrottlingDelayInMilliseconds > 0) | ||
| if (_totalThrottlingDelayInMilliseconds > _throttlingDelayReportThreshold) |
Collaborator
There was a problem hiding this comment.
Discussed offline, this is related to log lines and timeline record updates. Not general perf tarpitting.
Upload artifact, etc would be reported as 429 during that experience (depends on whether they log).
ericsciple
approved these changes
May 12, 2020
TingluoHuang
added a commit
that referenced
this pull request
May 12, 2020
* validate inputs only for repo action, no warning for small delay. * l0
Member
Author
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
…tions#476) * validate inputs only for repo action, no warning for small delay. * l0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/c2c-actions-service/issues/1051