Node 24 upgrade #624
Merged
Node 24 upgrade #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing an upgrade for node 24, node 24 is stricter with types so need to add a type for achitecture
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to Node.js 24, which enforces stricter type checking requirements. The main change introduces a new Architecture type to satisfy Node 24's stricter typing for architecture parameters.
- Adds a new
Architecturetype as a string alias to match @actions/tool-cache expectations - Updates all architecture-related function parameters and variables to use the new type
- Sets minimum Node.js engine requirement to 24.0.0
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.ts | Introduces new Architecture type definition |
| src/system.ts | Updates getArch function parameter to use Architecture type |
| src/main.ts | Adds type casting for architecture inputs to Architecture type |
| src/installer.ts | Updates all architecture parameters across multiple functions to use Architecture type |
| package.json | Sets Node.js engine requirement to >=24.0.0 |
priyagupta108
previously approved these changes
Aug 20, 2025
aparnajyothi-y
previously approved these changes
Aug 20, 2025
ad6b4cb
priyagupta108
previously approved these changes
Aug 26, 2025
aparnajyothi-y
previously approved these changes
Aug 26, 2025
83e99e7
ad6b4cb to
83e99e7
Compare
priyagupta108
approved these changes
Sep 3, 2025
aparnajyothi-y
approved these changes
Sep 3, 2025
HarithaVattikuti
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing an upgrade for node 24, node 24 is stricter with types so need to add a type for achitecture
Description:
Describe your changes.
Related issue:
Add link to the related issue.
Check list: