Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated jetbrains test: https.request() now catches errors. This fixes leaking tests as well #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brunoborges merged 3 commits into from
Jul 2, 2026
+20 −10
Merged

Updated jetbrains test: https.request() now catches errors. This fixes leaking tests as well #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9e99fb
Updated jetbrains https.request command to catch errors. This fixes l…
jmjaffe37 Jul 1, 2026
c30ae11
Removed deprecated lines from pre-commit and pre-push
jmjaffe37 Jul 1, 2026
d4d1939
added suggestion from PR feedback
jmjaffe37 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/usr/bin/env sh
Comment thread
brunoborges marked this conversation as resolved.
. "$(dirname -- "$0")/_/husky.sh"

npx lint-staged
3 changes: 0 additions & 3 deletions .husky/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run build && npm test
24 changes: 20 additions & 4 deletions __tests__/distributors/jetbrains-installer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,26 @@ describe('findPackageForDownload', () => {
const url = resolvedVersion.url;
const options = {method: 'HEAD'};

https.request(url, options, res => {
// JetBrains uses 403 for inexistent packages
expect(res.statusCode).not.toBe(403);
res.resume();
await new Promise<void>((resolve, reject) => {
const request = https.request(url, options, res => {
let assertionError: unknown;

try {
// JetBrains uses 403 for non-existent packages
expect(res.statusCode).not.toBe(403);
} catch (error) {
assertionError = error;
}

res.resume();
res.once('error', reject);
res.once('end', () =>
assertionError ? reject(assertionError as Error) : resolve()
);
});

request.on('error', reject);
request.end();
});
}
);
Expand Down
Loading