Add version parsing from Pipfile #1067

aradkdj · 2025-03-27T03:04:40Z

Description:
Add version parsing from a Pipfile, passed through the python-version-file option.

Related issue:
#574

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

mahabaleshwars · 2025-06-04T02:49:45Z

Hi @aradkdj,
The checks are currently failing on your PR. Could you please address the issues and pull the latest updates from the main branch? Once that's done, we can proceed with the review.

Thanks!

mahabaleshwars · 2025-06-09T03:02:14Z

Hi @aradkdj,
The checks are still failing. Please review the previous feedback comment, and let me know if you need any assistance to move forward.

aradkdj · 2025-06-10T06:12:44Z

Sure. I took a look at it and could not figure out why it's failing on CI but not on the unit tests. Any pointer would be appreciated

mahabaleshwars · 2025-06-12T03:09:42Z

Hi @aradkdj,
This issue is occurring due to an incorrect file name specified in the .yml file. It should be 'Pipfile' instead of 'Pipenv'. The logic performs a strict check on the file name:

else if (versionFile.match('Pipfile')) {
  return getVersionInputFromPipfileFile(versionFile);
}

Since 'Pipenv' doesn't match 'Pipfile', the corresponding logic isn't triggered. Please update the file name to resolve the issue.

aradkdj · 2025-06-13T15:22:46Z

Sorry I missed that. It should be fixed now

mahabaleshwars · 2025-06-20T02:09:17Z

Hi @aradkdj,
It looks like some checks are currently failing for this pull request. To help get this PR ready for review, could you please make sure your changes are up to date with the latest changes in setup-python? You can rebase or merge as necessary.

If you need any help interpreting the logs or fixing a specific error, feel free to share the error details here and we can assist further.

aradkdj · 2025-06-20T02:41:30Z

Merged and checked if the dist changes. But it didn't. If I understand the errors correctly they come from annotations about the installed pip version. Is there anything else I could do to fix it?

mahabaleshwars · 2025-06-20T10:59:48Z

Hi @aradkdj,
It looks like the issue is still not resolved — your PR branch might be missing the latest changes from main. Please update your forked repo’s main branch with the upstream setup-python, and then merge those changes into your branch.
After updating, please rebuild the dist files and push the changes.

aradkdj · 2025-07-06T01:29:31Z

@mahabaleshwars this should be passing now. Sorry for the delay

Copilot

Pull Request Overview

This PR adds support for parsing Python versions from a Pipfile via the python-version-file option.

Introduces getVersionInputFromPipfileFile and hooks it into getVersionInputFromFile.
Updates docs and CI workflows to demonstrate and test Pipfile usage.
Adds unit tests covering python_version, python_full_version, and empty Pipfile cases.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/utils.ts	Implement `getVersionInputFromPipfileFile` and integrate it
docs/advanced-usage.md	Document how to use Pipfile with `python-version-file`
tests/utils.test.ts	Add tests for Pipfile parsing scenarios
.github/workflows/test-python.yml	Add Pipfile-based setup jobs for `python_version` and `python_full_version`
.github/workflows/test-python-freethreaded.yml	Add equivalent Pipfile jobs in the freethreaded workflow

src/utils.ts

Co-authored-by: Copilot <[email protected]>

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0. Release notes *Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).* > v6.0.0 > ------ > > What's Changed > -------------- > > ### Breaking Changes > > * Upgrade to node 24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-python#1164](https://redirect.github.com/actions/setup-python/pull/1164) > > Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > ### Enhancements: > > * Add support for `pip-version` by [`@priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1129](https://redirect.github.com/actions/setup-python/pull/1129) > * Enhance reading from .python-version by [`@krystof-k`](https://github.com/krystof-k) in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787) > * Add version parsing from Pipfile by [`@aradkdj`](https://github.com/aradkdj) in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067) > > ### Bug fixes: > > * Clarify pythonLocation behaviour for PyPy and GraalPy in environment variables by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1183](https://redirect.github.com/actions/setup-python/pull/1183) > * Change missing cache directory error to warning by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1182](https://redirect.github.com/actions/setup-python/pull/1182) > * Add Architecture-Specific PATH Management for Python with --user Flag on Windows by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1122](https://redirect.github.com/actions/setup-python/pull/1122) > * Include python version in PyPy python-version output by [`@cdce8p`](https://github.com/cdce8p) in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110) > * Update docs: clarification on pip authentication with setup-python by [`@priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#1156](https://redirect.github.com/actions/setup-python/pull/1156) > > ### Dependency updates: > > * Upgrade idna from 2.9 to 3.7 in /**tests**/data by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#843](https://redirect.github.com/actions/setup-python/pull/843) > * Upgrade form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1163](https://redirect.github.com/actions/setup-python/pull/1163) > * Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIndex.download by [`@aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#1165](https://redirect.github.com/actions/setup-python/pull/1165) > * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1181](https://redirect.github.com/actions/setup-python/pull/1181) > * Upgrade `@actions/tool-cache` from 2.0.1 to 2.0.2 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-python#1095](https://redirect.github.com/actions/setup-python/pull/1095) > > New Contributors > ---------------- > > * [`@krystof-k`](https://github.com/krystof-k) made their first contribution in [actions/setup-python#787](https://redirect.github.com/actions/setup-python/pull/787) > * [`@cdce8p`](https://github.com/cdce8p) made their first contribution in [actions/setup-python#1110](https://redirect.github.com/actions/setup-python/pull/1110) > * [`@aradkdj`](https://github.com/aradkdj) made their first contribution in [actions/setup-python#1067](https://redirect.github.com/actions/setup-python/pull/1067) > > **Full Changelog**: <actions/setup-python@v5...v6.0.0> Commits * [`e797f83`](actions/setup-python@e797f83) Upgrade to node 24 ([#1164](https://redirect.github.com/actions/setup-python/issues/1164)) * [`3d1e2d2`](actions/setup-python@3d1e2d2) Revert "Enhance cache-dependency-path handling to support files outside the w... * [`65b0712`](actions/setup-python@65b0712) Clarify pythonLocation behavior for PyPy and GraalPy in environment variables... * [`5b668cf`](actions/setup-python@5b668cf) Bump actions/checkout from 4 to 5 ([#1181](https://redirect.github.com/actions/setup-python/issues/1181)) * [`f62a0e2`](actions/setup-python@f62a0e2) Change missing cache directory error to warning ([#1182](https://redirect.github.com/actions/setup-python/issues/1182)) * [`9322b3c`](actions/setup-python@9322b3c) Upgrade setuptools to 78.1.1 to fix path traversal vulnerability in PackageIn... * [`fbeb884`](actions/setup-python@fbeb884) Bump form-data to fix critical vulnerabilities [#182](https://redirect.github.com/actions/setup-python/issues/182) & [#183](https://redirect.github.com/actions/setup-python/issues/183) ([#1163](https://redirect.github.com/actions/setup-python/issues/1163)) * [`03bb615`](actions/setup-python@03bb615) Bump idna from 2.9 to 3.7 in /**tests**/data ([#843](https://redirect.github.com/actions/setup-python/issues/843)) * [`36da51d`](actions/setup-python@36da51d) Add version parsing from Pipfile ([#1067](https://redirect.github.com/actions/setup-python/issues/1067)) * [`3c6f142`](actions/setup-python@3c6f142) update documentation ([#1156](https://redirect.github.com/actions/setup-python/issues/1156)) * Additional commits viewable in [compare view](actions/setup-python@a26af69...e797f83) [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-python&package-manager=github\_actions&previous-version=5.6.0&new-version=6.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

aradkdj requested a review from a team as a code owner March 27, 2025 03:04

aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from f387444 to 0fc6a29 Compare May 30, 2025 23:11

aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from 0fc6a29 to c44ab2e Compare June 4, 2025 03:16

mahabaleshwars self-assigned this Jun 9, 2025

aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from c44ab2e to e87e3e9 Compare June 12, 2025 23:20

aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch 2 times, most recently from 4302de9 to 9485ba7 Compare June 25, 2025 17:02

aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from 9485ba7 to ee0eb5b Compare July 4, 2025 21:50

feature: add version parsing from Pipfile

b62f6a8

aradkdj force-pushed the feature/add-version-parsing-from-Pipfile branch from ee0eb5b to b62f6a8 Compare July 6, 2025 00:45

HarithaVattikuti requested a review from Copilot July 11, 2025 03:10

Copilot AI reviewed Jul 11, 2025

View reviewed changes

src/utils.ts Outdated Show resolved Hide resolved

src/utils.ts Outdated Show resolved Hide resolved

src/utils.ts Show resolved Hide resolved

aradkdj and others added 4 commits July 11, 2025 12:05

Update utils.ts

8681d8c

Co-authored-by: Copilot <[email protected]>

Update src/utils.ts

7b8a9f9

Co-authored-by: Copilot <[email protected]>

Update src/utils.ts

a67c49f

Co-authored-by: Copilot <[email protected]>

chore: update dist/setup/index.js

5eea597

mahabaleshwars approved these changes Jul 16, 2025

View reviewed changes

lmvysakh approved these changes Jul 16, 2025

View reviewed changes

aparnajyothi-y approved these changes Jul 18, 2025

View reviewed changes

HarithaVattikuti approved these changes Jul 24, 2025

View reviewed changes

HarithaVattikuti merged commit 36da51d into actions:main Jul 24, 2025
1299 checks passed

mahabaleshwars mentioned this pull request Jul 31, 2025

Fetching Python version from Pipenv's Pipfile #574

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add version parsing from Pipfile #1067

Add version parsing from Pipfile #1067

Uh oh!

aradkdj commented Mar 27, 2025

Uh oh!

mahabaleshwars commented Jun 4, 2025

Uh oh!

mahabaleshwars commented Jun 9, 2025

Uh oh!

aradkdj commented Jun 10, 2025

Uh oh!

mahabaleshwars commented Jun 12, 2025

Uh oh!

aradkdj commented Jun 13, 2025

Uh oh!

mahabaleshwars commented Jun 20, 2025

Uh oh!

aradkdj commented Jun 20, 2025

Uh oh!

mahabaleshwars commented Jun 20, 2025

Uh oh!

aradkdj commented Jul 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Add version parsing from Pipfile #1067

Add version parsing from Pipfile #1067

Uh oh!

Conversation

aradkdj commented Mar 27, 2025

Uh oh!

mahabaleshwars commented Jun 4, 2025

Uh oh!

mahabaleshwars commented Jun 9, 2025

Uh oh!

aradkdj commented Jun 10, 2025

Uh oh!

mahabaleshwars commented Jun 12, 2025

Uh oh!

aradkdj commented Jun 13, 2025

Uh oh!

mahabaleshwars commented Jun 20, 2025

Uh oh!

aradkdj commented Jun 20, 2025

Uh oh!

mahabaleshwars commented Jun 20, 2025

Uh oh!

aradkdj commented Jul 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!