Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix cross-platform build matrix example #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2020
Merged

Fix cross-platform build matrix example #65

merged 1 commit into from
Mar 5, 2020

Conversation

pastelmind
Copy link
Contributor

@pastelmind pastelmind commented Mar 5, 2020 •
edited
Loading

This commit fixes a faulty Workflow example in the README, which may confuse users. The current example actually runs all jobs under ubuntu-latest, because matrix.os is not being used by the runs-on field.

When running a job under multiple OSes, the runs-on field must use the matrix.os context property, as described in this official documentation for a multi-OS build matrix.

madhurig
madhurig approved these changes Mar 5, 2020
View reviewed changes
Copy link

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@madhurig madhurig merged commit ebe4d7e into actions:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhurig madhurig madhurig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pastelmind @madhurig