Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add GraalPy support #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 10, 2023
Merged

Add GraalPy support #694

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ad7b7ba
Add support for graalpy
timfel Jun 27, 2023
f40a022
add graalpy test workflow
timfel Jun 28, 2023
6db14b2
format, lint and build
timfel Jun 30, 2023
928058c
symlink graalpy binaries names
timfel Jun 30, 2023
b695933
fix macos names for graalpy
timfel Aug 21, 2023
b271e81
Don't attempt to update pip for graalpy
msimacek Aug 25, 2023
fb29473
Remove test schedule
msimacek Aug 29, 2023
08f6b91
Extract common getBinaryDirectory function for PyPy and GraalPy
msimacek Aug 29, 2023
3d8a1eb
Clean up and format
msimacek Aug 29, 2023
62fe528
Pass GitHub token to GraalPy queries
msimacek Aug 29, 2023
feb1894
Utilize pagination when querying GraalPy GitHub releases
msimacek Aug 29, 2023
7673153
Build
msimacek Aug 29, 2023
546edbc
Fix lint errors
msimacek Aug 30, 2023
8c79e75
Deal with possible multiple artifacts for a single releases
msimacek Aug 30, 2023
cc7e956
Skip few GraalPy tests on windows - we don't have a windows release yet
msimacek Aug 30, 2023
7f48d18
Fix GraalPy test on Mac OS
msimacek Aug 30, 2023
5b60f8c
Build
msimacek Aug 30, 2023
6713183
Skip one more GraalPy test on windows
msimacek Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix macos names for graalpy
  • Loading branch information
@timfel
timfel committed Aug 21, 2023
commit b69593376d4c33b67437ce9af6e9b38e6a912b8d
8 changes: 6 additions & 2 deletions dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69735,10 +69735,14 @@ function findAsset(item, architecture, platform) {
: architecture === 'arm64'
? 'aarch64'
: architecture;
const graalpyPlatform = platform == 'win32' ? 'windows' : platform;
const graalpyPlatform = platform === 'win32'
? 'windows'
: platform === 'darwin'
? 'macos'
: platform;
if (item.assets) {
return item.assets.find((file) => {
const match_data = file.name.match('.*(darwin|linux|windows)-(amd64|aarch64).tar.gz$');
const match_data = file.name.match('.*(macos|linux|windows)-(amd64|aarch64).tar.gz$');
return (match_data &&
match_data[1] === graalpyPlatform &&
match_data[2] === graalpyArch);
Expand Down
11 changes: 8 additions & 3 deletions src/install-graalpy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,16 @@ export function findAsset(
: architecture === 'arm64'
? 'aarch64'
: architecture;
const graalpyPlatform = platform == 'win32' ? 'windows' : platform;
if (item.assets) {
const graalpyPlatform =
platform === 'win32'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change it to IS_WINDOWS from utils.ts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform here is a parameter to the function. I think it would be weird if it overrode the passed parameter with the current platform.

? 'windows'
: platform === 'darwin'
? 'macos'
: platform;
if (item.assets) {
return item.assets.find((file: IGraalPyManifestAsset) => {
const match_data = file.name.match(
'.*(darwin|linux|windows)-(amd64|aarch64).tar.gz$'
'.*(macos|linux|windows)-(amd64|aarch64).tar.gz$'
);
return (
match_data &&
Expand Down