Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stale-issue/pr-message is required even if skip-stale-issue/pr-message is set to true #405

@neverendingqs

Description

@neverendingqs

stale-issue-message / stale-pr-message should probably not be required if skip-stale-issue-message / skip-stale-pr-message is set to true, since that string never gets used.

Workaround: set skip-stale-issue-message / skip-stale-pr-message to a non-empty string.

I think this happens because the check for a commit message (

const shouldMarkAsStale: boolean = shouldMarkWhenStale(daysBeforeStale);
if (!staleMessage && shouldMarkAsStale) {
issueLogger.info(`Skipping $$type due to empty stale message`);
continue;
}
) comes before we check if an issue is stale (
if (!issue.isStale && shouldBeStale && shouldMarkAsStale) {
issueLogger.info(
`Marking $$type stale because it was last updated on ${issue.updated_at} and it does not have a stale label`
);
await this._markStale(issue, staleMessage, staleLabel, skipMessage);
).

Example workflow: https://github.com/neverendingqs/serverless-dotenv-plugin/blob/8c02adbc653a90d681d5ededbb40300677cb8eac/.github/workflows/issues-cron.yml

Example run: https://github.com/neverendingqs/serverless-dotenv-plugin/runs/2209947040?check_suite_focus=true#step:2:35

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions