Backport test against Rails 8.0 #8556
Conversation
|
@mgrunberg do you want some help in completing this? I can allocate some time |
@tagliala thanks for the offer. If you can, please give me a hand. I won't we able to work on this until the end of the month so the help is very welcome. |
07e6fde to
30b34ee
Compare
- Downgrade zeitwerk to allow 3.1 - Use Ruby 3.0 to update Rails 7.0 and 7.1 dependencies ``` BUNDLE_GEMFILE=gemfiles/rails_70/Gemfile rvm use 3.0.7 do bash -c "bundle update && bundle update --bundler" BUNDLE_GEMFILE=gemfiles/rails_71/Gemfile rvm use 3.0.7 do bash -c "bundle update && bundle update --bundler" ```
5ff3449 to
4a8394d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8556 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4965
Branches ? 0
=============================================
Hits ? 4925
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| let(:arbre_context) do | ||
| OpenStruct.new(params: params, helpers: helpers, assigns: {}) | ||
| Struct.new(:params, :helpers, :assigns).new(params, helpers, {}) |
There was a problem hiding this comment.
This is required to allow specs to pass. Apparently, ostruct should be explicitly required after some changes to the dependencies but it is not used on master anymore and I've changed it to struct for parity
There was a problem hiding this comment.
Yes, that's right, thank you for doing this as we don't want to use OpenStruct in general.
Backport #8500