Remove double bottom border on last table row #8761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For when using the table_for component directly its best to remove the bottom border on the last table row for a consistent display. This way a simple border on the table can be added as needed without causing a double border at the bottom. Since the paginated-collection-pagination is optional we have to apply the top border just like we do for the paginated-collection-footer which follows it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8761 +/- ##
=========================================
Coverage ? 99.11%
=========================================
Files ? 141
Lines ? 4074
Branches ? 0
=========================================
Hits ? 4038
Misses ? 36
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double bottom border issue became apparent on using the table_for component in the dev app kitchen_sink page. This removes the bottom border on the last table row for a consistent display and so the table itself can get a simple border when needed. Since the paginated-collection-pagination element is optional we have to apply the top border just like we do for the paginated-collection-footer which follows it to maintain the same display as before.