CyberSource REST: Add commerce_indicator option override#5552
Open
romankhadka wants to merge 1 commit into
Open
CyberSource REST: Add commerce_indicator option override#5552romankhadka wants to merge 1 commit into
romankhadka wants to merge 1 commit into
Conversation
|
To provide a cleaner slate for the maintenance of the library, this PR/Issue is being labeled stale after 60 days without activity. It will be closed in 14 days unless you comment with an update regarding its applicability to the current build. Thank you! |
Author
|
Update: this still applies to the current build. PR #5552 is mergeable against current Verification run locally with Ruby 3.2.2 across the CI gemfiles (
Each gemfile run completed with 48 tests, 249 assertions, 0 failures, and 0 errors. Please keep this PR open. |
The CyberSource REST API accepts many values for processingInformation.commerceIndicator (moto, retail, recurring, install, internet, etc.) but the gateway only computes three of them from stored_credential reason_type. The SOAP gateway already supports an options[:commerce_indicator] pass-through; this brings parity to the REST gateway. Add add_commerce_indicator that runs after add_stored_credentials in build_auth_request, allowing callers to override the computed indicator with any valid value. When the option is absent, existing behavior is unchanged.
119d271 to
a81b9fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CyberSource REST API accepts many values for
processingInformation.commerceIndicator(moto,retail,recurring,install,internet, etc.) but the gateway only computes three of them fromstored_credential[:reason_type].The SOAP gateway (
CyberSourceGateway) already supportsoptions[:commerce_indicator]as a direct pass-through (line 843). This brings the same capability to the REST gateway for parity.Use Case
MOTO (Mail Order/Telephone Order) transactions require
commerceIndicator: "moto". Without this option, there is no way to set it via the REST gateway. The CyberSource docs listmotoas one of many valid indicator values.Changes
add_commerce_indicatorprivate method that appliesoptions[:commerce_indicator]as a final override afteradd_stored_credentialsinbuild_auth_requestadd_*method convention used by every other line inbuild_auth_requestTests
test_commerce_indicator_override— verifies override with"moto"on a regular credit cardtest_commerce_indicator_override_with_stored_credentials— verifies override takes precedence over stored credential computed value