Avoid error when microcontroller>Pin import fails #93

ilario · 2023-10-19T14:56:47Z

When running

>>> from adafruit_ads1x15.analog_in import AnalogIn

without having python3-libgpiod installed, I got this not-very-clear error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/dist-packages/adafruit_ads1x15/analog_in.py", line 16, in <module>
    from .ads1x15 import ADS1x15
  File "/usr/local/lib/python3.9/dist-packages/adafruit_ads1x15/ads1x15.py", line 58, in <module>
    class ADS1x15:
  File "/usr/local/lib/python3.9/dist-packages/adafruit_ads1x15/ads1x15.py", line 142, in ADS1x15
    def read(self, pin: Pin, is_differential: bool = False) -> int:
NameError: name 'Pin' is not defined

This happens because the import of microcontroller > Pin here

Adafruit_CircuitPython_ADS1x15/adafruit_ads1x15/ads1x15.py

Lines 22 to 28 in 588051a

    
           try: 
        
               from typing import Dict, List, Optional 
        
               from busio import I2C 
        
               from microcontroller import Pin 
        
           except ImportError: 
        
               pass

is failing due to the lack of python3-libgpiod. And the actually useful error message is not shown as it gets caught by try, which is ok, as microcontroller>Pin is not needed for running the thing.

The error I observed is caused by the mention of Pin here:

Adafruit_CircuitPython_ADS1x15/adafruit_ads1x15/ads1x15.py

Line 142 in 588051a

def read(self, pin: Pin, is_differential: bool = False) -> int:

Adafruit_CircuitPython_ADS1x15/adafruit_ads1x15/ads1x15.py

Line 163 in 588051a

def _read(self, pin: Pin) -> int:

No idea why the Python interpreter (I am on Python 3.9.2) cares about the type hints.

FoamyGuy

Thank you.

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.2.24 from 2.2.23: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#93 from ilario/Pin Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.4.12 from 5.4.11: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#119 from CedarGroveStudios/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.4.0 from 2.3.20: > Merge pull request adafruit/Adafruit_CircuitPython_PN532#66 from symm/mifare-value-block Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.4.3 from 7.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#179 from vladak/handle_on_message_vs_self Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries

ads1x15.py: define Pin if import fails

e12f9f4

ilario force-pushed the Pin branch from 9ff36db to e12f9f4 Compare October 19, 2023 15:24

FoamyGuy approved these changes Oct 23, 2023

View reviewed changes

FoamyGuy merged commit bb6ee16 into adafruit:main Oct 23, 2023

ilario mentioned this pull request Mar 27, 2025

Define I2C if busio.I2C import fails adafruit/Adafruit_CircuitPython_INA219#39

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid error when microcontroller>Pin import fails #93

Avoid error when microcontroller>Pin import fails #93

ilario commented Oct 19, 2023 •

edited

Loading

FoamyGuy left a comment

	try:
	from typing import Dict, List, Optional

	from busio import I2C
	from microcontroller import Pin
	except ImportError:
	pass

Avoid error when microcontroller>Pin import fails #93

Avoid error when microcontroller>Pin import fails #93

Conversation

ilario commented Oct 19, 2023 • edited Loading

FoamyGuy left a comment

Choose a reason for hiding this comment

ilario commented Oct 19, 2023 •

edited

Loading