Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Create send_batch_data method #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2021
Merged

Create send_batch_data method #70

merged 4 commits into from
May 6, 2021

Conversation

rodrigoargumedo
Copy link
Contributor

@rodrigoargumedo rodrigoargumedo commented Apr 30, 2021 •
edited
Loading

This would allow CircuitPython to send a batch array of data to be created from all available devices to the Adafruit.IO service. I will require further testing in all of my CircuitPython devices in the coming days and will mark this for review once it is complete.

Closes #72

Reference: https://io.adafruit.com/api/docs/?python#create-multiple-data-records

@tannewt tannewt requested a review from brentru April 30, 2021 17:36
Create send_batch_data method
d030d22 
Additionally, Define the data variable as an empty array.
@rodrigoargumedo rodrigoargumedo mentioned this pull request May 1, 2021
Closed
@brentru
Copy link
Member

brentru commented May 3, 2021

@rodrigoargumedo This is marked as a draft PR - is it ready for review yet? What's blocking it?

@rodrigoargumedo
Copy link
Contributor Author

rodrigoargumedo commented May 3, 2021 •
edited
Loading

@brentru The only code block is the unexpected JSON parsing error when I tested it with my Matrix Portal. It sounded pretty odd, but I was expecting something a value would be sent to the service itself.

I used a simple test method to make sure that it works. If you want, we can review it together.

@rodrigoargumedo rodrigoargumedo marked this pull request as ready for review May 3, 2021 14:16
@rodrigoargumedo
Copy link
Contributor Author

I may believe that I incorrectly put the POST method instead of directing the send_data method, which could've been expected.

@rodrigoargumedo rodrigoargumedo marked this pull request as draft May 4, 2021 00:50
@rodrigoargumedo
Copy link
Contributor Author

I found the solution and getting some more tests readying up soon.

@rodrigoargumedo rodrigoargumedo marked this pull request as ready for review May 4, 2021 01:36
@rodrigoargumedo
Copy link
Contributor Author

Now, I am ready for code review.

@brentru
Copy link
Member

brentru commented May 5, 2021

@rodrigoargumedo Could you post an example code.py that you're using to test this with so I can see how this function would be implemented?

brentru
brentru requested changes May 5, 2021
View reviewed changes
@rodrigoargumedo
Copy link
Contributor Author

I'll do those changes tonight and push them. Thanks! 👍

@brentru
Copy link
Member

brentru commented May 6, 2021

Thanks for making these changes.

@brentru brentru merged commit 12abfc9 into adafruit:master May 6, 2021
@rodrigoargumedo rodrigoargumedo deleted the create-multiple-records branch May 8, 2021 17:49
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 11, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
0a4fcd5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#17 from jposada202020/replacing_named_tuple

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#17 from jposada202020/adding_waitingtime_as_option

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#13 from jposada202020/adding_readme_note

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.9 from 2.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#30 from jposada202020/returning_correct_units_gyro

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#17 from jposada202020/correcting_returning_units_gyro

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.10.0 from 1.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#36 from xorbit/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.3.0 from 5.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#70 from rodrigoargumedo/create-multiple-records

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.0.1 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#78 from flavio-fernandes/fix.issue.77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create multiple records are not implemented in CircuitPython
2 participants
@rodrigoargumedo @brentru