Remove workaround for MiniMQTT (Issue #25) #14
Conversation
|
@jimbobbennett I can't tag you as a reviewer. However, could you please review this? Thanks! |
|
I invited @jimbobbennett to collaborate on the repo so they can review officially and merge. |
|
Thanks, Scott! |
adafruit_azureiot/iot_mqtt.py
Outdated
| @@ -91,7 +91,7 @@ def device_twin_desired_updated(self, desired_property_name: str, desired_proper | |||
| :param int desired_version: The version of the desired property that was updated | |||
| """ | |||
|
|
|||
| def device_twin_reported_updated(self, reported_property_name: str, reported_property_value, reported_version: int) -> None: | |||
| def device_twin_reported_updated(self, reported_property_name: str, reported_property_value, reported_version: int,) -> None: | |||
There was a problem hiding this comment.
Does this extra comma do anything?
There was a problem hiding this comment.
@jimbobbennett Hrm, I didn't add them. These may have been added by black'ing the file.
|
Noticed a few extra commas - not sure if they are needed. I'll do a full check and test later this week, sorry tied up the Microsoft Build at the moment. |
|
@jimbobbennett No rush, enjoy BUILD |
https://black.readthedocs.io/en/stable/the_black_code_style.html#trailing-commas |
|
@brentru - I've updated the PR with a couple of changes:
I've tested it on a PyPortal using a number of the examples. Can you review please? |
There was a problem hiding this comment.
@jimbobbennett This looks good to merge. I agree with relying on the generated hostname rather than passing the client creation method the hostname.
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#17 from caternuson/i2c_update Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#14 from brentru/patch-mmqtt
Removes library workaround patched in adafruit/Adafruit_CircuitPython_MiniMQTT#33 in favor of using hostname without
https:appended to the broker string