Rename .reset ._reset as per issue #28 #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
May 15, 2019
|
@peterhinch hiya to check did you try running this code or this is a blind-fix? |
|
Unfortunately I have no hardware capable of running CircuitPython (Scott Shawcroft has promised to send me some). Until this arrives I have to rely on others to test these PR's. FWIW I can see no further problems with this driver. |
|
@peterhinch I'm waiting to get an email from you. ([email protected]) If you sent one please follow up. I must have missed it. |
|
My first email must have ended up in the great /dev/null. I've sent another. |
|
Hardware with CircuitPython now arrived (thanks, guys). @ladyada I've now tested this by running bno055_simpletest.py successfully. |
|
awesome thank you :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 23, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.1.1 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#37 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#3 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#13 from tannewt/remove_stop > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#12 from s-light/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#36 from tannewt/remove_stop > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#31 from peterhinch/rename-reset Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#10 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#34 from tannewt/remove_stop > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#32 from caternuson/minor_tweaks > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#31 from caternuson/fix_lint > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#30 from caternuson/remove_temp Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#16 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.9.0 from 1.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#67 from brentru/add-get-time Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#10 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.0.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#8 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.0.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#11 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.0.4 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#15 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.2.3 from 3.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#18 from tannewt/remove_stop > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#17 from adafruit/revert-16-add-blinka-to-requirements-txt > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#16 from demophoon/add-blinka-to-requirements-txt Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#11 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.0.3 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#19 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.1.4 from 3.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#13 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#22 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP006 to 2.0.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_TMP006#5 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP007 to 2.0.0 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_TMP007#5 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#25 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#10 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.0.0 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#30 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.7.2 from 1.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_Register#27 from tannewt/remove_stop Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_JWT, Adafruit_CircuitPython_NTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement name change as approved solution to issue #28.