-
Notifications
You must be signed in to change notification settings - Fork 50
Added typing and made an edit to fix a typing issue (non-breaking) #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Nov 1, 2022
tekktrik
requested changes
Nov 1, 2022
tekktrik
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 11, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.4.4 from 3.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#73 from BiffoBear/add_typing > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.19 from 5.1.18: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#73 from crotwell/extra_underscore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.4.6 from 1.4.5: > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#22 from grouma/main > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 6.0.0 from 5.5.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#125 from BiffoBear/Make_is_connected_return_bool > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type hints to all functions. Edited
character_lcd.color
setter to resolve a typing conflict with afloat
used when anint
was expected in the linepin.duty_cycle = int(_map(color[number], 0, 100, 65535, 0))
. Convertedr
,g
andb
fromfloat
toint
.This matches the intent of the doc-string:
BTW,
character_lcd._set_bit()
is not called anywhere and can be deleted.